Xuanwo commented on code in PR #2909:
URL:
https://github.com/apache/incubator-opendal/pull/2909#discussion_r1302609824
##########
core/src/services/s3/core.rs:
##########
@@ -433,7 +433,7 @@ impl S3Core {
}
let mut req = req
- .header(constants::X_AMZ_COPY_SOURCE, percent_encode_path(&source))
+ .header(constants::X_AMZ_COPY_SOURCE, &source)
Review Comment:
You can add a test case here:
https://github.com/apache/incubator-opendal/blob/main/core/tests/behavior/write.rs
> NOTE: This PR is good enough for merging. It's okay if you don't want to
do any additional work. Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
