tisonkun commented on code in PR #2910:
URL:
https://github.com/apache/incubator-opendal/pull/2910#discussion_r1302771339
##########
bindings/java/pom.xml:
##########
@@ -199,6 +198,9 @@
</goals>
<configuration>
<classifier>${jni.classifier}</classifier>
+ <includes>
Review Comment:
Tested locally the use case work as expected. The content of JAR ball is:
```
➜ java git:(pkg-java) unzip -t
~/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar
Archive:
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar
testing: META-INF/ OK
testing: META-INF/MANIFEST.MF OK
testing: native/ OK
testing: native/osx-aarch_64/ OK
testing: META-INF/maven/ OK
testing: META-INF/maven/org.apache.opendal/ OK
testing: META-INF/maven/org.apache.opendal/opendal-java/ OK
testing: native/osx-aarch_64/libopendal_java.dylib OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.xml OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.properties
OK
No errors detected in compressed data of
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar.
➜ java git:(pkg-java) unzip -t
~/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar
Archive:
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar
testing: META-INF/ OK
testing: META-INF/MANIFEST.MF OK
testing: org/ OK
testing: org/apache/ OK
testing: org/apache/opendal/ OK
testing: META-INF/maven/ OK
testing: META-INF/maven/org.apache.opendal/ OK
testing: META-INF/maven/org.apache.opendal/opendal-java/ OK
testing: META-INF/DEPENDENCIES OK
testing: META-INF/LICENSE OK
testing: META-INF/NOTICE OK
testing: bindings.properties OK
testing: org/apache/opendal/BlockingOperator.class OK
testing: org/apache/opendal/Environment.class OK
testing: org/apache/opendal/Metadata.class OK
testing: org/apache/opendal/NativeObject$LibraryState.class OK
testing: org/apache/opendal/NativeObject.class OK
testing: org/apache/opendal/OpenDALException$Code.class OK
testing: org/apache/opendal/OpenDALException.class OK
testing: org/apache/opendal/Operator$AsyncRegistry.class OK
testing: org/apache/opendal/Operator.class OK
testing: org/apache/opendal/package-info.class OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.xml OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.properties
OK
No errors detected in compressed data of
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar.
```
##########
bindings/java/pom.xml:
##########
@@ -199,6 +198,9 @@
</goals>
<configuration>
<classifier>${jni.classifier}</classifier>
+ <includes>
Review Comment:
Tested locally the use case work as expected. The content of JAR ball is:
```
➜ java git:(pkg-java) unzip -t
~/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar
Archive:
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar
testing: META-INF/ OK
testing: META-INF/MANIFEST.MF OK
testing: native/ OK
testing: native/osx-aarch_64/ OK
testing: META-INF/maven/ OK
testing: META-INF/maven/org.apache.opendal/ OK
testing: META-INF/maven/org.apache.opendal/opendal-java/ OK
testing: native/osx-aarch_64/libopendal_java.dylib OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.xml OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.properties
OK
No errors detected in compressed data of
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT-osx-aarch_64.jar.
➜ java git:(pkg-java) unzip -t
~/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar
Archive:
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar
testing: META-INF/ OK
testing: META-INF/MANIFEST.MF OK
testing: org/ OK
testing: org/apache/ OK
testing: org/apache/opendal/ OK
testing: META-INF/maven/ OK
testing: META-INF/maven/org.apache.opendal/ OK
testing: META-INF/maven/org.apache.opendal/opendal-java/ OK
testing: META-INF/DEPENDENCIES OK
testing: META-INF/LICENSE OK
testing: META-INF/NOTICE OK
testing: bindings.properties OK
testing: org/apache/opendal/BlockingOperator.class OK
testing: org/apache/opendal/Environment.class OK
testing: org/apache/opendal/Metadata.class OK
testing: org/apache/opendal/NativeObject$LibraryState.class OK
testing: org/apache/opendal/NativeObject.class OK
testing: org/apache/opendal/OpenDALException$Code.class OK
testing: org/apache/opendal/OpenDALException.class OK
testing: org/apache/opendal/Operator$AsyncRegistry.class OK
testing: org/apache/opendal/Operator.class OK
testing: org/apache/opendal/package-info.class OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.xml OK
testing: META-INF/maven/org.apache.opendal/opendal-java/pom.properties
OK
No errors detected in compressed data of
/Users/tison/.m2/repository/org/apache/opendal/opendal-java/0.40.0-SNAPSHOT/opendal-java-0.40.0-SNAPSHOT.jar.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
