raboof commented on PR #2918: URL: https://github.com/apache/incubator-opendal/pull/2918#issuecomment-1690472077
This is indeed a reasonable way to make sure the NOTICE contains correct years. For example, commons-collections [does something similar](https://github.com/apache/commons-collections/blob/master/NOTICE.txt). An alternative approach is to make sure [`inceptionYear`](https://maven.apache.org/pom.html#More_Project_Information) and [`project.build.outputTimestamp`](https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build) are set to a 'realistic' values before starting the release process. For example maven-remote-resources-plugin [does this](https://github.com/apache/maven-remote-resources-plugin/commit/2fb369bc7c29e219683e1b0a72e0ca9e75b09d1c#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R71) (automatically via maven-release-plugin, even - but you might not be using that). The latter approach still has the timezone problem mentioned earlier - though it is much less likely to be encountered for 'realistic' dates. https://github.com/apache/maven-remote-resources-plugin/pull/39 should fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
