Xuanwo commented on code in PR #2941:
URL:
https://github.com/apache/incubator-opendal/pull/2941#discussion_r1306349762
##########
core/src/services/s3/backend.rs:
##########
@@ -1052,6 +1052,7 @@ impl Accessor for S3Backend {
match status {
StatusCode::NO_CONTENT => Ok(RpDelete::default()),
+ StatusCode::NOT_FOUND => Ok(RpDelete::default()), // allow 404
when deleting a non-existing object
Review Comment:
Please make it more clear that it's not a standard behavior, only some s3
alike service like gcs xml api do this.
And please add comments upper this line instead of after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
