Xuanwo commented on code in PR #2950:
URL:
https://github.com/apache/incubator-opendal/pull/2950#discussion_r1306927049
##########
bindings/tests/features/binding.feature:
##########
@@ -32,3 +32,7 @@ Feature: OpenDAL Binding
Then The async file "test" entry mode must be file
Then The async file "test" content length must be 13
Then The async file "test" must have content "Hello, World!"
+
+ Scenario: OpenDAL Operations with Presign
+ Given A new OpenDAL Async Operator (s3 presign only)
Review Comment:
> We need an available operator to test presign function here.
No. Please don't mix bindings test with rust core's behavior test.
Binding test is used to make sure the binding implement correctly: the call
is passed to rust core and got a response back from rust core. The presign
itself doesn't need to be tested: they are covered by rust core's behavior test.
In the future, we can extend those test with more services like fs and s3.
But all of them sure be exact the same test suites.
> Or we can implement a fake presign function for `memory`.
No. We can't implement this for `memory`.
##########
bindings/tests/features/binding.feature:
##########
@@ -32,3 +32,7 @@ Feature: OpenDAL Binding
Then The async file "test" entry mode must be file
Then The async file "test" content length must be 13
Then The async file "test" must have content "Hello, World!"
+
+ Scenario: OpenDAL Operations with Presign
+ Given A new OpenDAL Async Operator (s3 presign only)
Review Comment:
> We need an available operator to test presign function here.
No. Please don't mix bindings test with rust core's behavior test.
Binding test is used to make sure the binding implement correctly: the call
is passed to rust core and got a response back from rust core. The presign
itself doesn't need to be tested: they are covered by rust core's behavior test.
In the future, we can extend those test with more services like fs and s3.
But all of them sure be exact the same test suite.
> Or we can implement a fake presign function for `memory`.
No. We can't implement this for `memory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
