Xuanwo commented on code in PR #2944:
URL:
https://github.com/apache/incubator-opendal/pull/2944#discussion_r1306995377
##########
bin/oay/src/services/webdav/webdavfs.rs:
##########
@@ -156,8 +162,16 @@ impl DavFileSystem for WebdavFs {
fn rename<'a>(&'a self, from: &'a DavPath, to: &'a DavPath) ->
dav_server::fs::FsFuture<()> {
async move {
+ let from_path = from
+ .as_rel_ospath()
+ .to_str()
+ .ok_or(FsError::GeneralFailure)?;
+ let to_path =
to.as_rel_ospath().to_str().ok_or(FsError::GeneralFailure)?;
+ if from.is_collection() {
Review Comment:
I don't think it works for s3, but it's OK to merge first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
