Young-Flash commented on code in PR #2971:
URL:
https://github.com/apache/incubator-opendal/pull/2971#discussion_r1309006585
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus
http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus
http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
If there are failed tests, litmus still exit with `0`, which will pass the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
