Xuanwo commented on code in PR #2988:
URL:
https://github.com/apache/incubator-opendal/pull/2988#discussion_r1312463666
##########
bindings/cpp/CMakeLists.txt:
##########
@@ -80,4 +80,25 @@ if(APPLE)
endif()
include(GoogleTest)
-gtest_discover_tests(opendal_cpp_test)
\ No newline at end of file
+gtest_discover_tests(opendal_cpp_test)
+
+# Documentation
+set(PROJECT_DOCUMENT_SOURCE ${CMAKE_SOURCE_DIR}/include
${CMAKE_SOURCE_DIR}/README.md)
+string(REPLACE ";" " " PROJECT_DOCUMENT_SOURCE "${PROJECT_DOCUMENT_SOURCE}")
+file(DOWNLOAD
https://raw.githubusercontent.com/jothepro/doxygen-awesome-css/main/doxygen-awesome.css
${CMAKE_BINARY_DIR}/doxygen-awesome.css)
Review Comment:
Please don't download from github raw content, use CDN instead, for example:
https://cdn.jsdelivr.net/gh/jothepro/[email protected]/doxygen-awesome.min.css
Benefits:
- Pinned to version 2.2.1
- Minimize on demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
