silver-ymz commented on PR #3004: URL: https://github.com/apache/incubator-opendal/pull/3004#issuecomment-1704674164
The `reader` implementation mimics [`gcs sdk`](https://github.com/googleapis/google-cloud-cpp/blob/6b45ae7050929f7c23a90844cae9f71284fafe59/google/cloud/storage/internal/object_read_streambuf.cc#L146C65-L146C65). It only uses std to provide a reader suitable for `std::istream`. If we use boost to provide a more high-level API. The [`Input-seekable device`](https://www.boost.org/doc/libs/1_83_0/libs/iostreams/doc/guide/modes.html) of `iostream` library seems better. `asio::basic_file` seems not suitable to derive and make custom io file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
