suyanhanx commented on PR #3008: URL: https://github.com/apache/incubator-opendal/pull/3008#issuecomment-1707641865
I think this change is good, but the renaming is unacceptable. Although it changes the acceptable type of the content, it does not align with the general concept of a pipe, which involves data transmission/ communication as a pipe.It remains a sink,performing the final consumption action. This renaming makes the modification difficult to accept without a rfc or issue for discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
