Xuanwo commented on code in PR #3023:
URL:
https://github.com/apache/incubator-opendal/pull/3023#discussion_r1319653108
##########
core/src/services/fs/backend.rs:
##########
@@ -566,10 +566,15 @@ impl Accessor for FsBackend {
(p, None)
};
- let f = std::fs::OpenOptions::new()
- .create(true)
- .truncate(true)
- .write(true)
+ let mut open_option = std::fs::OpenOptions::new();
+ open_option.create(true).write(true);
+ if args.append() {
Review Comment:
We should handle append carefully since the file could already been exist.
##########
core/tests/behavior/main.rs:
##########
@@ -41,13 +41,15 @@ use read_only::behavior_read_only_tests;
use rename::behavior_rename_tests;
use write::behavior_write_tests;
+mod blocking_append;
Review Comment:
Maybe put under `// Blocking test cases`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
