Xuanwo commented on code in PR #3029:
URL:
https://github.com/apache/incubator-opendal/pull/3029#discussion_r1321363151
##########
core/src/services/gdrive/writer.rs:
##########
@@ -59,13 +58,7 @@ impl GdriveWriter {
match status {
StatusCode::OK | StatusCode::CREATED => {
- let bs = resp.into_body().bytes().await?;
-
- let file = serde_json::from_slice::<GdriveFile>(&bs)
- .map_err(new_json_deserialize_error)?;
-
- self.file_id = Some(file.id);
-
+ resp.into_body().consume().await?;
Review Comment:
> As gdrive allows files to hold the same name, without reusing the file id,
it will be a problem.
I didn't get your idea. Maybe you can add a test case to cover them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
