Xuanwo commented on code in PR #3072:
URL:
https://github.com/apache/incubator-opendal/pull/3072#discussion_r1326329895
##########
core/src/raw/ops.rs:
##########
@@ -209,6 +209,27 @@ impl From<OpWrite> for PresignOperation {
}
}
+impl From<OpStat> for OpRead {
Review Comment:
Hi, OpenDAL prioritizes optimization for reading as our code typically only
needs to be changed once but may be read by multiple developers. So we will
spend more time to write readable and maintainable code instead.
I can see the potential benefit of converting between `OpRead` and `OpStat`
since they share most fields. However, allowing convert `OpRead`/`OpStat` makes
reader feel confused. Everytime we read a `into()`, we need to figure which
type we are using.
So I prefer to remove those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
