This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 79139ee4d refactor(services/webdav): Refactor `webdav_put` signatures
by using `OpWrite`. (#3076)
79139ee4d is described below
commit 79139ee4db02a2bf440cee69be2cf819fd594b35
Author: -LAN- <[email protected]>
AuthorDate: Fri Sep 15 03:09:40 2023 +0800
refactor(services/webdav): Refactor `webdav_put` signatures by using
`OpWrite`. (#3076)
---
core/src/services/webdav/backend.rs | 7 +++----
core/src/services/webdav/writer.rs | 3 +--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/core/src/services/webdav/backend.rs
b/core/src/services/webdav/backend.rs
index 1f9aa1019..8d8771472 100644
--- a/core/src/services/webdav/backend.rs
+++ b/core/src/services/webdav/backend.rs
@@ -437,8 +437,7 @@ impl WebdavBackend {
&self,
abs_path: &str,
size: Option<u64>,
- content_type: Option<&str>,
- content_disposition: Option<&str>,
+ args: &OpWrite,
body: AsyncBody,
) -> Result<Response<IncomingAsyncBody>> {
let url = format!("{}/{}", self.endpoint,
percent_encode_path(abs_path));
@@ -453,11 +452,11 @@ impl WebdavBackend {
req = req.header(header::CONTENT_LENGTH, size)
}
- if let Some(mime) = content_type {
+ if let Some(mime) = args.content_type() {
req = req.header(header::CONTENT_TYPE, mime)
}
- if let Some(cd) = content_disposition {
+ if let Some(cd) = args.content_disposition() {
req = req.header(header::CONTENT_DISPOSITION, cd)
}
diff --git a/core/src/services/webdav/writer.rs
b/core/src/services/webdav/writer.rs
index 42de4fc0e..7bf365b00 100644
--- a/core/src/services/webdav/writer.rs
+++ b/core/src/services/webdav/writer.rs
@@ -47,8 +47,7 @@ impl oio::OneShotWrite for WebdavWriter {
.webdav_put(
&self.path,
Some(bs.len() as u64),
- self.op.content_type(),
- self.op.content_disposition(),
+ &self.op,
AsyncBody::ChunkedBytes(bs),
)
.await?;