Xuanwo commented on code in PR #3129:
URL:
https://github.com/apache/incubator-opendal/pull/3129#discussion_r1329643130
##########
.github/workflows/service_test_redis.yml:
##########
@@ -192,3 +192,26 @@ jobs:
OPENDAL_REDIS_ENDPOINT: tcp://127.0.0.1:6379
OPENDAL_REDIS_ROOT: /
OPENDAL_REDIS_DB: 0
+
+ binding_java_redis:
Review Comment:
Is it possible to make it a matrix so that we can test core, binding/java,
bindings/python, ...?
##########
bindings/java/src/test/java/org/apache/opendal/services/S3Test.java:
##########
Review Comment:
Can we init without writing files for every service?
##########
bindings/java/README.md:
##########
@@ -62,16 +62,48 @@ You can use Maven to build both Rust dynamic lib and JAR
files with one command
./mvnw clean package -DskipTests=true
```
+## Setup Tests
+
+Please copy `.env.example` to `src/test/resources/.env` and change the values
on need.
Review Comment:
So we can read `.env` directly like `dotenvy` does?
##########
bindings/java/.env.example:
##########
@@ -0,0 +1,166 @@
+# memory
Review Comment:
Can we reuse the `.env` in the top-level dir?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
