Young-Flash commented on code in PR #3119: URL: https://github.com/apache/incubator-opendal/pull/3119#discussion_r1334399650
########## integrations/dav-server/src/file.rs: ########## @@ -0,0 +1,98 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::io::SeekFrom; + +use bytes::Bytes; +use dav_server::davpath::DavPath; +use dav_server::fs::DavFile; +use dav_server::fs::DavMetaData; +use dav_server::fs::FsFuture; +use futures::FutureExt; +use opendal::Operator; + +use super::metadata::WebdavMetaData; + +#[derive(Debug)] +pub struct WebdavFile { + op: Operator, + path: DavPath, +} + +impl WebdavFile { + pub fn new(op: Operator, path: DavPath) -> Self { + Self { op, path } + } +} + +impl DavFile for WebdavFile { + fn read_bytes(&mut self, count: usize) -> FsFuture<Bytes> { + async move { + let file_path = self.path.as_url_string(); + self.op + .read_with(&file_path) + .range(0..count as u64) + .await + .map(Bytes::from) + .map_err(convert_error) + } + .boxed() + } + + fn metadata(&mut self) -> FsFuture<Box<dyn DavMetaData>> { + async move { + self.op + .stat(self.path.as_url_string().as_str()) + .await + .map(|opendal_metadata| { + Box::new(WebdavMetaData::new(opendal_metadata)) as Box<dyn DavMetaData> + }) + .map_err(convert_error) + } + .boxed() + } + + fn write_buf(&mut self, buf: Box<dyn bytes::Buf + Send>) -> FsFuture<()> { + self.write_bytes(Bytes::copy_from_slice(buf.chunk())) + } + + fn write_bytes(&mut self, buf: Bytes) -> FsFuture<()> { + async move { + let file_path = self.path.as_url_string(); + self.op.write(&file_path, buf).await.map_err(convert_error) Review Comment: Sorry, can you be more detailed? Isn't writing the file from beginning a expected behavior here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
