G-XD commented on code in PR #3233: URL: https://github.com/apache/incubator-opendal/pull/3233#discussion_r1349619616
########## core/src/services/libsql/backend.rs: ########## @@ -0,0 +1,345 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; +use std::fmt::Debug; + +use async_trait::async_trait; +use libsql_client::{args, Config, Statement, SyncClient, Value}; Review Comment: > BTW, libsql_client looks like a simple wrapper around reqwest. Maybe we can build request by ourselves? > > https://docs.rs/libsql-client/latest/src/libsql_client/reqwest.rs.html#17-39 I didn't find standard api documentation for the libsql service, and I realized that the libsql sdk from a few months ago doesn't work with the latest version of libsql anymore. Would it take more effort to maintain api changes if we build http requests directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
