Xuanwo commented on code in PR #3295: URL: https://github.com/apache/incubator-opendal/pull/3295#discussion_r1360232641
########## website/docs/services/d1.mdx: ########## @@ -0,0 +1,81 @@ +--- +title: D1 +--- + +[D1](https://developers.cloudflare.com/d1/) services support. + +import Docs from '../../../core/src/services/d1/docs.md' + +<Docs components={props.components} /> + +### Via Config + +import Tabs from '@theme/Tabs'; +import TabItem from '@theme/TabItem'; + +<Tabs> + <TabItem value="rust" label="Rust" default> + +```rust +use anyhow::Result; +use opendal::services::D1; +use opendal::Operator; + +#[tokio::main] +async fn main() -> Result<()> { + + let mut map = HashMap::new(); + map.insert("root".to_string(), "your_root_directory".to_string()); + map.insert("token".to_string(), "your_token".to_string()); + map.insert("account_identifier".to_string(), "your_account_identifier".to_string()); Review Comment: I recall reviewing it to change to `account_id`. ########## website/docs/services/d1.mdx: ########## @@ -0,0 +1,81 @@ +--- +title: D1 +--- + +[D1](https://developers.cloudflare.com/d1/) services support. + +import Docs from '../../../core/src/services/d1/docs.md' + +<Docs components={props.components} /> + +### Via Config + +import Tabs from '@theme/Tabs'; +import TabItem from '@theme/TabItem'; + +<Tabs> + <TabItem value="rust" label="Rust" default> + +```rust +use anyhow::Result; +use opendal::services::D1; +use opendal::Operator; + +#[tokio::main] +async fn main() -> Result<()> { + + let mut map = HashMap::new(); + map.insert("root".to_string(), "your_root_directory".to_string()); + map.insert("token".to_string(), "your_token".to_string()); + map.insert("account_identifier".to_string(), "your_account_identifier".to_string()); + map.insert("database_identifier".to_string(), "your_database_identifier".to_string()); + map.insert("endpoint".to_string(), "your_endpoint".to_string()); Review Comment: And endpoint should have been removed. Maybe the doc source is outdated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
