This is an automated email from the ASF dual-hosted git repository.

suyanhanx pushed a commit to branch random-root-nodejs-test
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git


The following commit(s) were added to refs/heads/random-root-nodejs-test by 
this push:
     new 66426f80a remove original test job
66426f80a is described below

commit 66426f80aff96ffd165bf6f1841aa28ae1d588e2
Author: suyanhanx <[email protected]>
AuthorDate: Wed Nov 1 20:15:37 2023 +0800

    remove original test job
    
    Signed-off-by: suyanhanx <[email protected]>
---
 .../behavior_test_binding_nodejs/action.yaml       | 44 +++++++++++-----------
 .github/services/azdls/azdls/action.yml            |  8 ++--
 .github/workflows/bindings_nodejs.yml              | 44 ----------------------
 .../sftp/docker-compose-sftp-with-default-root.yml | 10 +----
 fixtures/sftp/docker-compose-sftp.yml              | 10 +----
 5 files changed, 30 insertions(+), 86 deletions(-)

diff --git a/.github/actions/behavior_test_binding_nodejs/action.yaml 
b/.github/actions/behavior_test_binding_nodejs/action.yaml
index cc2c64b0e..b5ac84cbf 100644
--- a/.github/actions/behavior_test_binding_nodejs/action.yaml
+++ b/.github/actions/behavior_test_binding_nodejs/action.yaml
@@ -28,25 +28,25 @@ inputs:
 runs:
   using: "composite"
   steps:
-      - name: Setup
-        shell: bash
-        run: |
-            mkdir -p ./dynamic_test_binding_nodejs &&
-            cat <<EOF >./dynamic_test_binding_nodejs/action.yml
-            runs:
-              using: composite
-              steps:
-              - name: Setup Test
-                uses: ./.github/services/${{ inputs.service }}/${{ 
inputs.setup }}
-              - name: Run Test Binding NodeJS
-                shell: bash
-                working-directory: bindings/nodejs
-                run: |
-                    yarn build:debug
-                    yarn test
-                env:
-                  NAPI_FEATURES: ${{ inputs.feature }}
-                  OPENDAL_TEST: ${{ inputs.service }}
-            EOF
-      - name: Run
-        uses: ./dynamic_test_binding_nodejs
+    - name: Setup
+      shell: bash
+      run: |
+        mkdir -p ./dynamic_test_binding_nodejs &&
+        cat <<EOF >./dynamic_test_binding_nodejs/action.yml
+        runs:
+          using: composite
+          steps:
+          - name: Setup Test
+            uses: ./.github/services/${{ inputs.service }}/${{ inputs.setup }}
+          - name: Run Test Binding NodeJS
+            shell: bash
+            working-directory: bindings/nodejs
+            run: |
+                yarn build:debug
+                yarn test
+            env:
+              NAPI_FEATURES: ${{ inputs.feature }}
+              OPENDAL_TEST: ${{ inputs.service }}
+        EOF
+    - name: Run
+      uses: ./dynamic_test_binding_nodejs
diff --git a/.github/services/azdls/azdls/action.yml 
b/.github/services/azdls/azdls/action.yml
index 60f3c3ed8..4ac4ab01e 100644
--- a/.github/services/azdls/azdls/action.yml
+++ b/.github/services/azdls/azdls/action.yml
@@ -26,10 +26,10 @@ runs:
       with:
         export-env: true
       env:
-          OPENDAL_AZDLS_FILESYSTEM: op://services/azdls/filesystem
-          OPENDAL_AZDLS_ENDPOINT: op://services/azdls/endpoint
-          OPENDAL_AZDLS_ACCOUNT_NAME: op://services/azdls/account_name
-          OPENDAL_AZDLS_ACCOUNT_KEY: op://services/azdls/account_key
+        OPENDAL_AZDLS_FILESYSTEM: op://services/azdls/filesystem
+        OPENDAL_AZDLS_ENDPOINT: op://services/azdls/endpoint
+        OPENDAL_AZDLS_ACCOUNT_NAME: op://services/azdls/account_name
+        OPENDAL_AZDLS_ACCOUNT_KEY: op://services/azdls/account_key
     - name: Add extra settings
       shell: bash
       run: |
diff --git a/.github/workflows/bindings_nodejs.yml 
b/.github/workflows/bindings_nodejs.yml
index d81815d6f..59c37ff9e 100644
--- a/.github/workflows/bindings_nodejs.yml
+++ b/.github/workflows/bindings_nodejs.yml
@@ -36,42 +36,6 @@ on:
   workflow_dispatch:
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-
-    # Notes: this defaults only apply on run tasks.
-    defaults:
-      run:
-        working-directory: "bindings/nodejs"
-
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup Rust toolchain
-        uses: ./.github/actions/setup
-      - name: Setup node
-        uses: actions/setup-node@v3
-        with:
-          node-version: '18'
-          cache: yarn
-          cache-dependency-path: "bindings/nodejs/yarn.lock"
-
-      - name: Corepack
-        run: corepack enable
-      - name: Install dependencies
-        run: yarn install --immutable
-
-      - name: Check format
-        run: yarn run prettier --check .
-
-      - name: Build
-        run: yarn build:debug
-
-      - name: Check diff
-        run: git diff --exit-code
-
-      - name: Test bindings
-        run: yarn test
-
   linux:
     runs-on: ubuntu-latest
     if: "startsWith(github.ref, 'refs/tags/')"
@@ -107,8 +71,6 @@ jobs:
         with:
           name: bindings-linux
           path: bindings/nodejs/*.node
-      - name: Test bindings
-        run: yarn test
 
   windows:
     runs-on: windows-latest
@@ -137,8 +99,6 @@ jobs:
         with:
           name: bindings-windows
           path: bindings/nodejs/*.node
-      - name: Test bindings
-        run: yarn test
 
   macos:
     runs-on: macos-latest
@@ -190,10 +150,6 @@ jobs:
         with:
           name: bindings-macos-${{ matrix.settings.target }}
           path: bindings/nodejs/*.node
-      - name: Test bindings
-        if: ${{ matrix.settings.test }}
-        run: ${{ matrix.settings.test }}
-        shell: bash
 
   release:
     name: Release
diff --git a/fixtures/sftp/docker-compose-sftp-with-default-root.yml 
b/fixtures/sftp/docker-compose-sftp-with-default-root.yml
index a02e91ad8..e650e73ea 100644
--- a/fixtures/sftp/docker-compose-sftp-with-default-root.yml
+++ b/fixtures/sftp/docker-compose-sftp-with-default-root.yml
@@ -33,13 +33,7 @@ services:
         hard: 65536
     command: foo::::upload
     healthcheck:
-      test:
-        [
-          "CMD-SHELL",
-          "bash",
-          "-c",
-          "/health-check.sh"
-        ]
+      test: ["CMD-SHELL", "bash", "-c", "/health-check.sh"]
       interval: 10s
       timeout: 10s
-      retries: 5
\ No newline at end of file
+      retries: 5
diff --git a/fixtures/sftp/docker-compose-sftp.yml 
b/fixtures/sftp/docker-compose-sftp.yml
index d090565ae..b3314985b 100644
--- a/fixtures/sftp/docker-compose-sftp.yml
+++ b/fixtures/sftp/docker-compose-sftp.yml
@@ -32,13 +32,7 @@ services:
         hard: 65536
     command: foo::::upload
     healthcheck:
-      test:
-        [
-          "CMD-SHELL",
-          "bash",
-          "-c",
-          "/health-check.sh"
-        ]
+      test: ["CMD-SHELL", "bash", "-c", "/health-check.sh"]
       interval: 10s
       timeout: 10s
-      retries: 5
\ No newline at end of file
+      retries: 5

Reply via email to