Xuanwo commented on code in PR #3456: URL: https://github.com/apache/incubator-opendal/pull/3456#discussion_r1378746036
########## .github/workflows/bindings_nodejs.yml: ########## @@ -36,42 +36,6 @@ on: workflow_dispatch: jobs: - test: - runs-on: ubuntu-latest - - # Notes: this defaults only apply on run tasks. - defaults: - run: - working-directory: "bindings/nodejs" - - steps: - - uses: actions/checkout@v4 - - name: Setup Rust toolchain - uses: ./.github/actions/setup - - name: Setup node - uses: actions/setup-node@v4 - with: - node-version: '18' - cache: yarn - cache-dependency-path: "bindings/nodejs/yarn.lock" - - - name: Corepack - run: corepack enable - - name: Install dependencies - run: yarn install --immutable - - - name: Check format - run: yarn run prettier --check . - - - name: Build - run: yarn build:debug - - - name: Check diff - run: git diff --exit-code - - - name: Test bindings - run: yarn test Review Comment: This workflow is still needed since we need to check, build and running unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
