Xuanwo commented on code in PR #3484:
URL:
https://github.com/apache/incubator-opendal/pull/3484#discussion_r1382513640
##########
bindings/nodejs/generated.js:
##########
@@ -271,10 +271,11 @@ if (!nativeBinding) {
throw new Error(`Failed to load native binding`)
}
-const { Operator, Entry, Metadata, Lister, BlockingLister } = nativeBinding
+const { Operator, Entry, Metadata, Lister, BlockingLister, RetryLayer } =
nativeBinding
module.exports.Operator = Operator
module.exports.Entry = Entry
module.exports.Metadata = Metadata
module.exports.Lister = Lister
module.exports.BlockingLister = BlockingLister
+module.exports.RetryLayer = RetryLayer
Review Comment:
We will expose `RetryLayer` directly as `opendal`? Do we need a
`opendal.layers`'s namespace?
##########
bindings/nodejs/tests/suites/index.mjs:
##########
@@ -36,7 +36,11 @@ export function runner(testName, scheme) {
config.root = generateRandomRoot(config.root)
}
- const operator = scheme ? new Operator(scheme, config) : null
+ let operator = scheme ? new Operator(scheme, config) : null
+
+ let retryLayer = new RetryLayer(true, 4)
Review Comment:
The API doesn't look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
