Xuanwo commented on code in PR #3499:
URL:
https://github.com/apache/incubator-opendal/pull/3499#discussion_r1384502751
##########
core/src/services/mysql/backend.rs:
##########
@@ -245,8 +263,8 @@ impl kv::Adapter for Adapter {
async fn set(&self, path: &str, value: &[u8]) -> Result<()> {
let query = format!(
- "INSERT INTO `{}` (`{}`, `{}`)
- VALUES (:path, :value)
+ "INSERT INTO `{}` (`{}`, `{}`)
Review Comment:
Please don't change unrelated part of code.
##########
core/src/services/mysql/backend.rs:
##########
@@ -22,14 +22,17 @@ use async_trait::async_trait;
use mysql_async::prelude::*;
use mysql_async::Opts;
use mysql_async::Pool;
+use serde::Deserialize;
use crate::raw::adapters::kv;
use crate::raw::*;
use crate::*;
-#[doc = include_str!("docs.md")]
-#[derive(Default)]
-pub struct MysqlBuilder {
+/// Config for PostGresQL services support.
Review Comment:
Wrong comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
