hoslo commented on code in PR #3498: URL: https://github.com/apache/incubator-opendal/pull/3498#discussion_r1384641907
########## core/src/services/redis/backend.rs: ########## @@ -42,10 +43,11 @@ use crate::*; const DEFAULT_REDIS_ENDPOINT: &str = "tcp://127.0.0.1:6379"; const DEFAULT_REDIS_PORT: u16 = 6379; -/// [Redis](https://redis.io/) services support. -#[doc = include_str!("docs.md")] -#[derive(Clone, Default)] -pub struct RedisBuilder { +/// Config for Redis services support. +#[derive(Default, Deserialize, Clone)] +#[serde(default)] +#[non_exhaustive] +pub struct RedisConfig { Review Comment: ok, i modified it, but #3497 SqliteConfig is not public, Should it be modified? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
