Xuanwo commented on code in PR #3507: URL: https://github.com/apache/incubator-opendal/pull/3507#discussion_r1384843350
########## core/src/services/http/backend.rs: ########## @@ -32,25 +32,43 @@ use super::error::parse_error; use crate::raw::*; use crate::*; -/// HTTP Read-only service support like [Nginx](https://www.nginx.com/) and [Caddy](https://caddyserver.com/). -#[doc = include_str!("docs.md")] -#[derive(Default)] -pub struct HttpBuilder { +use serde::Deserialize; + +/// Config for Http service support. +#[derive(Default, Deserialize)] +#[serde(default)] +#[non_exhaustive] +pub struct HttpConfig { Review Comment: Please make those fields `pub`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
