Xuanwo commented on code in PR #3514:
URL:
https://github.com/apache/incubator-opendal/pull/3514#discussion_r1385959232
##########
bindings/python/src/operator.rs:
##########
@@ -29,10 +29,9 @@ use crate::*;
fn build_operator(
scheme: ocore::Scheme,
map: HashMap<String, String>,
- blocking: bool,
) -> PyResult<ocore::Operator> {
let mut op = ocore::Operator::via_map(scheme, map).map_err(format_pyerr)?;
- if blocking && !op.info().full_capability().blocking {
Review Comment:
Adding BlockingLayer here is zero-cost:
- We are using the async runtime provided by pyo3.
- Only enabled while `blocking == false`
- Services support blocking is not changed
- Calling on blocking API on not supported services will spwan futures on
async runtime instead. (This won't happen for `AsyncOperator`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
