silver-ymz commented on code in PR #3519:
URL:
https://github.com/apache/incubator-opendal/pull/3519#discussion_r1386137748
##########
scripts/release.sh:
##########
@@ -38,6 +38,24 @@ mkdir -p dist/
echo "> Checkout version branch"
git checkout -B "${git_branch}"
+# Please update this part while package list changed.
+echo "> Update Cargo.toml to remove not released members"
+PACKAGES=(
+ "bindings\/c"
+ "bindings\/ruby"
+ "bindings\/haskell"
+ "bindings\/lua"
+ "bindings\/dotnet"
+ "bindings\/ocaml"
+ "bindings\/php"
+ "bindings\/cpp"
+ "bin\/"
+ "integrations\/"
+)
+for package in "${PACKAGES[@]}"; do
+ sed -i "/${package}/d" Cargo.toml
+done
+
echo "> Start package"
git archive --format=tar.gz
--output="dist/apache-opendal-incubating-$release_version-src.tar.gz"
--prefix="apache-opendal-incubating-$release_version-src/" "$git_branch"
Review Comment:
The issue still exists. We need to use
```suggestion
git archive --format=tar.gz
--output="dist/apache-opendal-incubating-$release_version-src.tar.gz"
--prefix="apache-opendal-incubating-$release_version-src/"
--add-file=Cargo.toml "$git_branch"
```
Should we open a new PR and start a new release `v0.42.0-rc.3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
