Xuanwo commented on code in PR #3484:
URL:
https://github.com/apache/incubator-opendal/pull/3484#discussion_r1391319418
##########
bindings/nodejs/src/lib.rs:
##########
@@ -15,6 +15,9 @@
// specific language governing permissions and limitations
// under the License.
+#![allow(clippy::not_unsafe_ptr_arg_deref)]
+/// This line exists here because of the `js_function` macro.
Review Comment:
Maybe we can remove this?
##########
.github/workflows/bindings_nodejs.yml:
##########
@@ -65,12 +63,12 @@ jobs:
- name: Check format
run: yarn run prettier --check .
+ - name: Build
Review Comment:
Maybe we can revert this change now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
