silver-ymz commented on code in PR #3581:
URL: 
https://github.com/apache/incubator-opendal/pull/3581#discussion_r1392042231


##########
bindings/cpp/.clang-format:
##########
@@ -0,0 +1,3 @@
+---

Review Comment:
   > CMake not contains a format job.
   
   We can add a custom target in cmake to let user able to use `make format` 
directly. e.x.
   ```
   add_custom_target(
       format
       ALL
       COMMAND /usr/bin/clang-format
       -i
       ${CPP_SOURCE_FILE}
       ${CPP_HEADER_FILE}
   )
   ```
   
   Also, Would you like to update ci to check format?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to