Xuanwo commented on code in PR #3600:
URL:
https://github.com/apache/incubator-opendal/pull/3600#discussion_r1396878465
##########
core/src/services/hdfs/backend.rs:
##########
@@ -85,6 +99,12 @@ impl HdfsBuilder {
}
self
}
+
+ /// Set enable_append of this backend
Review Comment:
Please add comments on why we need this and how to enable append support on
hdfs.
##########
core/src/services/hdfs/backend.rs:
##########
@@ -31,12 +32,25 @@ use crate::*;
/// [Hadoop Distributed File System (HDFS™)](https://hadoop.apache.org/)
support.
#[doc = include_str!("docs.md")]
-#[derive(Debug, Default)]
+#[derive(Debug)]
pub struct HdfsBuilder {
root: Option<String>,
name_node: Option<String>,
kerberos_ticket_cache_path: Option<String>,
user: Option<String>,
+ enable_append: bool,
+}
+
+impl Default for HdfsBuilder {
Review Comment:
So we don't need this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
