This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 52fa5ae3a refactor(services/rocksdb): migrate to test planner (#3636)
52fa5ae3a is described below
commit 52fa5ae3afd367ccc47184b765187735c472498d
Author: G-XD <[email protected]>
AuthorDate: Wed Nov 22 14:57:25 2023 +0800
refactor(services/rocksdb): migrate to test planner (#3636)
* refactor(services/rocksdb): migrate to test planner
* Don't link with static rocksbd
Signed-off-by: Xuanwo <[email protected]>
---------
Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Xuanwo <[email protected]>
---
.github/actions/setup/action.yaml | 1 -
.github/services/rocksdb/rocksdb/action.yml | 32 ++++++++++++++++
.github/workflows/service_test_rocksdb.yml | 59 -----------------------------
3 files changed, 32 insertions(+), 60 deletions(-)
diff --git a/.github/actions/setup/action.yaml
b/.github/actions/setup/action.yaml
index 73612026b..07b85a60f 100644
--- a/.github/actions/setup/action.yaml
+++ b/.github/actions/setup/action.yaml
@@ -82,7 +82,6 @@ runs:
run: |
# Set rocksdb lib path
echo "ROCKSDB_LIB_DIR=/tmp/rocksdb/lib" >> $GITHUB_ENV
- echo "ROCKSDB_STATIC=true" >> $GITHUB_ENV
- name: Cache rocksdb
id: cache-rocksdb
diff --git a/.github/services/rocksdb/rocksdb/action.yml
b/.github/services/rocksdb/rocksdb/action.yml
new file mode 100644
index 000000000..cc8ca96de
--- /dev/null
+++ b/.github/services/rocksdb/rocksdb/action.yml
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: rocksdb
+description: 'Behavior test for RocksDB'
+
+runs:
+ using: "composite"
+ steps:
+ - name: Setup
+ shell: bash
+ run: |
+ cat << EOF >> $GITHUB_ENV
+ LD_LIBRARY_PATH=/tmp/rocksdb/lib:${{ env.LD_LIBRARY_PATH }}
+ RUST_TEST_THREADS=1
+ OPENDAL_ROCKSDB_ROOT=/
+ OPENDAL_ROCKSDB_DATADIR=/tmp/opendal/rocksdb/
+ EOF
diff --git a/.github/workflows/service_test_rocksdb.yml
b/.github/workflows/service_test_rocksdb.yml
deleted file mode 100644
index 0a8d0c147..000000000
--- a/.github/workflows/service_test_rocksdb.yml
+++ /dev/null
@@ -1,59 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: Service Test RocksDB
-
-on:
- workflow_dispatch:
- push:
- branches:
- - main
- pull_request:
- branches:
- - main
- paths:
- - "core/src/**"
- - "core/tests/**"
- - "!core/src/docs/**"
- - "!core/src/services/**"
- - "core/src/services/rocksdb/**"
- - ".github/actions/setup/action.yaml"
- - ".github/workflows/service_test_rocksdb.yml"
-
-concurrency:
- group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
- cancel-in-progress: true
-
-jobs:
- rocksdb:
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@v4
- - name: Setup Rust toolchain
- uses: ./.github/actions/setup
- with:
- need-rocksdb: true
-
- - name: Test
- shell: bash
- working-directory: core
- run: cargo test behavior --features tests,services-rocksdb -j=1
- env:
- LD_LIBRARY_PATH: /tmp/rocksdb/lib:${{ env.LD_LIBRARY_PATH }}
- OPENDAL_TEST: rocksdb
- OPENDAL_ROCKSDB_ROOT: /
- OPENDAL_ROCKSDB_DATADIR: /tmp/opendal/rocksdb/
