This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
The following commit(s) were added to refs/heads/main by this push:
new be0853e48 chore(ci): nodejs binding publish dry run (#3632)
be0853e48 is described below
commit be0853e48f3d3547f8c42fed8279404c57e75321
Author: Suyan <[email protected]>
AuthorDate: Thu Nov 23 00:24:14 2023 +0800
chore(ci): nodejs binding publish dry run (#3632)
* chore(ci): binding nodejs publish dry run
Signed-off-by: suyanhanx <[email protected]>
* disable ftp for nodejs binding
Signed-off-by: suyanhanx <[email protected]>
* format
Signed-off-by: suyanhanx <[email protected]>
* add upgrade guide
Signed-off-by: suyanhanx <[email protected]>
* disable build all binary on normal job
Signed-off-by: suyanhanx <[email protected]>
* format
Signed-off-by: suyanhanx <[email protected]>
* polish
Signed-off-by: suyanhanx <[email protected]>
---------
Signed-off-by: suyanhanx <[email protected]>
---
.github/workflows/behavior_test_binding_nodejs.yml | 9 ++++--
.github/workflows/bindings_nodejs.yml | 37 +++++++++++++++-------
.github/workflows/docs.yml | 18 +++++++----
bindings/nodejs/Cargo.toml | 3 +-
bindings/nodejs/npm/darwin-x64/package.json | 2 +-
bindings/nodejs/npm/linux-arm64-gnu/package.json | 2 +-
bindings/nodejs/npm/linux-arm64-musl/package.json | 2 +-
bindings/nodejs/npm/win32-arm64-msvc/package.json | 2 +-
bindings/nodejs/upgrade.md | 5 +++
9 files changed, 54 insertions(+), 26 deletions(-)
diff --git a/.github/workflows/behavior_test_binding_nodejs.yml
b/.github/workflows/behavior_test_binding_nodejs.yml
index f3879154d..8f9769fbc 100644
--- a/.github/workflows/behavior_test_binding_nodejs.yml
+++ b/.github/workflows/behavior_test_binding_nodejs.yml
@@ -54,14 +54,17 @@ jobs:
connect-host: ${{ secrets.OP_CONNECT_HOST }}
connect-token: ${{ secrets.OP_CONNECT_TOKEN }}
- - name: Corepack
- working-directory: bindings/nodejs
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+
+ - name: Corepack
+ working-directory: bindings/nodejs
+ run: corepack enable
- name: Install dependencies
working-directory: bindings/nodejs
diff --git a/.github/workflows/bindings_nodejs.yml
b/.github/workflows/bindings_nodejs.yml
index a7bf1f330..6aeb897b5 100644
--- a/.github/workflows/bindings_nodejs.yml
+++ b/.github/workflows/bindings_nodejs.yml
@@ -49,14 +49,17 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup
- - name: Corepack
- run: corepack enable
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+
+ - name: Corepack
+ run: corepack enable
- name: Install dependencies
run: yarn install --immutable
@@ -128,14 +131,16 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Corepack
- run: corepack enable
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+ - name: Corepack
+ run: corepack enable
- name: Install dependencies
run: yarn install --immutable
- name: Build
@@ -158,9 +163,7 @@ jobs:
- target: aarch64-pc-windows-msvc
build: |
rustup target add aarch64-pc-windows-msvc;
- set NAPI_TARGET=aarch64-pc-windows-msvc;
- yarn build
-
+ NAPI_TARGET=aarch64-pc-windows-msvc yarn build
# Notes: this defaults only apply on run tasks.
defaults:
@@ -171,17 +174,20 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Corepack
- run: corepack enable
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+ - name: Corepack
+ run: corepack enable
- name: Install dependencies
run: yarn install --immutable
- name: Build
+ shell: bash
run: ${{ matrix.settings.build }}
- uses: actions/upload-artifact@v3
with:
@@ -220,14 +226,16 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Corepack
- run: corepack enable
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+ - name: Corepack
+ run: corepack enable
- name: Install dependencies
run: yarn install --immutable
- name: Build
@@ -279,6 +287,13 @@ jobs:
working-directory: .
run: cp LICENSE NOTICE ./bindings/nodejs
+ - name: Publish Dry Run
+ if: "startsWith(github.ref, 'refs/tags/') && contains(github.ref, '-')"
+ # Since this command will not exit with non-zero code when file
missing,
+ # we need to check the output manually.
+ run: |
+ npm publish --access public --provenance --dry-run
+
- name: Publish
if: "startsWith(github.ref, 'refs/tags/') && !contains(github.ref,
'-')"
run: |
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index cba5419ef..28fd1d145 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -90,14 +90,16 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Corepack
- working-directory: bindings/nodejs
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "bindings/nodejs/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+ - name: Corepack
+ working-directory: bindings/nodejs
+ run: corepack enable
- name: Install dependencies
working-directory: bindings/nodejs
@@ -292,15 +294,17 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Corepack
- working-directory: website
- run: corepack enable
-
- uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "website/yarn.lock"
+ env:
+ SKIP_YARN_COREPACK_CHECK: true
+
+ - name: Corepack
+ working-directory: website
+ run: corepack enable
- name: Download rust docs
uses: actions/download-artifact@v3
diff --git a/bindings/nodejs/Cargo.toml b/bindings/nodejs/Cargo.toml
index 9ad4eff0a..39949f711 100644
--- a/bindings/nodejs/Cargo.toml
+++ b/bindings/nodejs/Cargo.toml
@@ -56,7 +56,8 @@ services-all = [
"services-etcd",
# FIXME this requires a preinstalled fdb library
# "services-foundationdb",
- "services-ftp",
+ # FIXME waiting for this issue close
https://github.com/async-rs/async-tls/issues/55
+ # "services-ftp",
"services-gdrive",
# FIXME how to support HDFS services in bindings?
# "services-hdfs",
diff --git a/bindings/nodejs/npm/darwin-x64/package.json
b/bindings/nodejs/npm/darwin-x64/package.json
index e2a7508cd..d92c2e1c6 100644
--- a/bindings/nodejs/npm/darwin-x64/package.json
+++ b/bindings/nodejs/npm/darwin-x64/package.json
@@ -1,7 +1,7 @@
{
"name": "@opendal/lib-darwin-x64",
- "repository": "[email protected]/apache/incubator-opendal.git",
"version": "0.42.0",
+ "repository": "[email protected]/apache/incubator-opendal.git",
"os": [
"darwin"
],
diff --git a/bindings/nodejs/npm/linux-arm64-gnu/package.json
b/bindings/nodejs/npm/linux-arm64-gnu/package.json
index 8abe80cdd..e13ddc88a 100644
--- a/bindings/nodejs/npm/linux-arm64-gnu/package.json
+++ b/bindings/nodejs/npm/linux-arm64-gnu/package.json
@@ -1,7 +1,7 @@
{
"name": "@opendal/lib-linux-arm64-gnu",
- "repository": "[email protected]/apache/incubator-opendal.git",
"version": "0.42.0",
+ "repository": "[email protected]/apache/incubator-opendal.git",
"os": [
"linux"
],
diff --git a/bindings/nodejs/npm/linux-arm64-musl/package.json
b/bindings/nodejs/npm/linux-arm64-musl/package.json
index dbc7dd88f..b6218f693 100644
--- a/bindings/nodejs/npm/linux-arm64-musl/package.json
+++ b/bindings/nodejs/npm/linux-arm64-musl/package.json
@@ -1,7 +1,7 @@
{
"name": "@opendal/lib-linux-arm64-musl",
- "repository": "[email protected]/apache/incubator-opendal.git",
"version": "0.42.0",
+ "repository": "[email protected]/apache/incubator-opendal.git",
"os": [
"linux"
],
diff --git a/bindings/nodejs/npm/win32-arm64-msvc/package.json
b/bindings/nodejs/npm/win32-arm64-msvc/package.json
index e40dc00c1..c8f877606 100644
--- a/bindings/nodejs/npm/win32-arm64-msvc/package.json
+++ b/bindings/nodejs/npm/win32-arm64-msvc/package.json
@@ -1,7 +1,7 @@
{
"name": "@opendal/lib-win32-arm64-msvc",
- "repository": "[email protected]/apache/incubator-opendal.git",
"version": "0.42.0",
+ "repository": "[email protected]/apache/incubator-opendal.git",
"os": [
"win32"
],
diff --git a/bindings/nodejs/upgrade.md b/bindings/nodejs/upgrade.md
new file mode 100644
index 000000000..ba031d390
--- /dev/null
+++ b/bindings/nodejs/upgrade.md
@@ -0,0 +1,5 @@
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib
issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily
disable the `services-ftp`.
