(incubator-opendal) branch fix-stat updated: Fix java

[xuanwo]

This is an automated email from the ASF dual-hosted git repository.

xuanwo pushed a commit to branch fix-stat
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git


The following commit(s) were added to refs/heads/fix-stat by this push:
     new 36ba43911 Fix java
36ba43911 is described below

commit 36ba43911011034a554e1242fa681235a51925f7
Author: Xuanwo <git...@xuanwo.io>
AuthorDate: Thu Nov 23 12:02:43 2023 +0800

    Fix java
    
    Signed-off-by: Xuanwo <git...@xuanwo.io>
---
 bindings/java/src/main/java/org/apache/opendal/Capability.java     | 7 -------
 .../java/org/apache/opendal/test/behavior/AsyncCreateDirTest.java  | 1 -
 .../org/apache/opendal/test/behavior/BlockingCreateDirTest.java    | 1 -
 core/src/layers/complete.rs                                        | 4 ++--
 4 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/bindings/java/src/main/java/org/apache/opendal/Capability.java 
b/bindings/java/src/main/java/org/apache/opendal/Capability.java
index 15bd927ec..dfde61276 100644
--- a/bindings/java/src/main/java/org/apache/opendal/Capability.java
+++ b/bindings/java/src/main/java/org/apache/opendal/Capability.java
@@ -28,11 +28,6 @@ public class Capability {
      */
     public final boolean stat;
 
-    /**
-     *  If operator supports stat dir.
-     */
-    public final boolean statDir;
-
     /**
      * If operator supports stat with if matched.
      */
@@ -223,7 +218,6 @@ public class Capability {
 
     public Capability(
             boolean stat,
-            boolean statDir,
             boolean statWithIfMatch,
             boolean statWithIfNoneMatch,
             boolean read,
@@ -262,7 +256,6 @@ public class Capability {
             long batchMaxOperations,
             boolean blocking) {
         this.stat = stat;
-        this.statDir = statDir;
         this.statWithIfMatch = statWithIfMatch;
         this.statWithIfNoneMatch = statWithIfNoneMatch;
         this.read = read;
diff --git 
a/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncCreateDirTest.java
 
b/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncCreateDirTest.java
index affa47b81..6c81bd3a5 100644
--- 
a/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncCreateDirTest.java
+++ 
b/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncCreateDirTest.java
@@ -34,7 +34,6 @@ class AsyncCreateDirTest extends BehaviorTestBase {
     public void precondition() {
         final Capability capability = op().info.fullCapability;
         assumeTrue(capability.createDir);
-        assumeTrue(capability.statDir);
     }
 
     /**
diff --git 
a/bindings/java/src/test/java/org/apache/opendal/test/behavior/BlockingCreateDirTest.java
 
b/bindings/java/src/test/java/org/apache/opendal/test/behavior/BlockingCreateDirTest.java
index fc10abddd..24bb2fb91 100644
--- 
a/bindings/java/src/test/java/org/apache/opendal/test/behavior/BlockingCreateDirTest.java
+++ 
b/bindings/java/src/test/java/org/apache/opendal/test/behavior/BlockingCreateDirTest.java
@@ -34,7 +34,6 @@ class BlockingCreateDirTest extends BehaviorTestBase {
     public void precondition() {
         final Capability capability = blockingOp().info.fullCapability;
         assumeTrue(capability.createDir);
-        assumeTrue(capability.statDir);
     }
 
     /**
diff --git a/core/src/layers/complete.rs b/core/src/layers/complete.rs
index ec14da536..a536c6ca3 100644
--- a/core/src/layers/complete.rs
+++ b/core/src/layers/complete.rs
@@ -243,7 +243,7 @@ impl<A: Accessor> CompleteAccessor<A> {
             return Ok(RpStat::new(Metadata::new(EntryMode::DIR)));
         }
 
-        // Forward to inner if stat_dir is supported.
+        // Forward to inner if create dir is supported.
         if path.ends_with('/') && capability.create_dir {
             let meta = self.inner.blocking_stat(path, args)?.into_metadata();
 
@@ -257,7 +257,7 @@ impl<A: Accessor> CompleteAccessor<A> {
             return Ok(RpStat::new(Metadata::new(EntryMode::DIR)));
         }
 
-        // Otherwise, we can simulate `stat_dir` via `list`.
+        // Otherwise, we can simulate stat a dir path via `list`.
         if path.ends_with('/') && capability.list_with_recursive {
             let (_, mut l) = self.inner.blocking_list(
                 path.trim_end_matches('/'),