CookiePieWw commented on code in PR #3655:
URL:
https://github.com/apache/incubator-opendal/pull/3655#discussion_r1402936141
##########
core/src/services/azfile/core.rs:
##########
@@ -417,8 +417,8 @@ impl AzfileCore {
// azure file service does not support recursive directory creation
let mut p = path;
while p != "/" {
- p = get_parent(p);
dirs.push_front(p);
+ p = get_parent(p);
Review Comment:
Thanks for review.
The initial intent here is to avoid puting `"/"` into the `dirs`, but
ignoring the usage of the function.
~~Since the
[document](https://learn.microsoft.com/en-us/rest/api/storageservices/create-directory#request)
shows that the `Create Directory` request requires to format the dir like
`...path/to/dir...`, the problem may lie in the trailing `/` of the input path.
Is it a workable option to just trim the trailing `/`?~~
Got it
[here](https://learn.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata)
that the trailing slash will be auto removed. I'll try to figure the root
cause out later.
Still I'm not sure the meaning of `normalize the root` from the issue since
I haven't found something wrong about it. Could you give me a hint?
Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
