This is an automated email from the ASF dual-hosted git repository. xuanwo pushed a commit to branch polish-comments in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
commit 325e2cfcbecc03a7cea19649dc40654d2f789d19 Author: Xuanwo <[email protected]> AuthorDate: Thu Nov 23 16:49:15 2023 +0800 Fix binding c Signed-off-by: Xuanwo <[email protected]> --- bindings/c/tests/bdd.cpp | 1 - bindings/c/tests/opinfo.cpp | 54 ++++++++++++++++++++++++--------------------- 2 files changed, 29 insertions(+), 26 deletions(-) diff --git a/bindings/c/tests/bdd.cpp b/bindings/c/tests/bdd.cpp index 1de64da79..67b8f56b8 100644 --- a/bindings/c/tests/bdd.cpp +++ b/bindings/c/tests/bdd.cpp @@ -102,7 +102,6 @@ TEST_F(OpendalBddTest, FeatureTest) EXPECT_FALSE(opendal_metadata_last_modified_ms(meta) != -1); opendal_metadata_free(meta); - // The blocking file "test" must have content "Hello, World!" struct opendal_result_read r = opendal_operator_read(this->p, this->path.c_str()); EXPECT_EQ(r.error, nullptr); diff --git a/bindings/c/tests/opinfo.cpp b/bindings/c/tests/opinfo.cpp index 56e0bae3f..480364017 100644 --- a/bindings/c/tests/opinfo.cpp +++ b/bindings/c/tests/opinfo.cpp @@ -62,32 +62,36 @@ TEST_F(OpendalOperatorInfoTest, CapabilityTest) { opendal_capability full_cap = opendal_operator_info_get_full_capability(this->info); opendal_capability native_cap = opendal_operator_info_get_native_capability(this->info); - opendal_capability caps[2] = { full_cap, native_cap }; - for (int i = 0; i < 2; ++i) { - opendal_capability cap = caps[i]; - - EXPECT_TRUE(cap.blocking); - - EXPECT_TRUE(cap.read); - EXPECT_TRUE(cap.read_can_seek); - EXPECT_TRUE(cap.read_can_next); - EXPECT_TRUE(cap.read_with_range); - EXPECT_TRUE(cap.stat); - - EXPECT_TRUE(cap.write); - EXPECT_TRUE(cap.write_can_empty); - EXPECT_TRUE(cap.create_dir); - - EXPECT_TRUE(cap.delete_); - - EXPECT_TRUE(cap.list); - EXPECT_TRUE(cap.list_with_recursive); - - EXPECT_TRUE(cap.copy); - - EXPECT_TRUE(cap.rename); - } + EXPECT_TRUE(full_cap.blocking); + EXPECT_TRUE(full_cap.read); + EXPECT_TRUE(full_cap.read_can_seek); + EXPECT_TRUE(full_cap.read_can_next); + EXPECT_TRUE(full_cap.read_with_range); + EXPECT_TRUE(full_cap.stat); + EXPECT_TRUE(full_cap.write); + EXPECT_TRUE(full_cap.write_can_empty); + EXPECT_TRUE(full_cap.create_dir); + EXPECT_TRUE(full_cap.delete_); + EXPECT_TRUE(full_cap.list); + EXPECT_TRUE(full_cap.list_with_recursive); + EXPECT_TRUE(full_cap.copy); + EXPECT_TRUE(full_cap.rename); + + EXPECT_TRUE(native_cap.blocking); + EXPECT_TRUE(native_cap.read); + EXPECT_TRUE(native_cap.read_can_seek); + EXPECT_TRUE(native_cap.read_can_next); + EXPECT_TRUE(native_cap.read_with_range); + EXPECT_TRUE(native_cap.stat); + EXPECT_TRUE(native_cap.write); + EXPECT_TRUE(native_cap.write_can_empty); + EXPECT_FALSE(native_cap.create_dir); + EXPECT_TRUE(native_cap.delete_); + EXPECT_TRUE(native_cap.list); + EXPECT_TRUE(native_cap.list_with_recursive); + EXPECT_TRUE(native_cap.copy); + EXPECT_TRUE(native_cap.rename); } TEST_F(OpendalOperatorInfoTest, InfoTest)
