Xuanwo commented on code in PR #3680:
URL:
https://github.com/apache/incubator-opendal/pull/3680#discussion_r1413125698
##########
website/src/components/committers/index.jsx:
##########
@@ -0,0 +1,53 @@
+import React from 'react'
+import styles from './index.module.css'
+
+// Sorted by apacheId
+const committers = [
+ { githubId: 'ClSlaid', apacheId: 'cailue', name: 'Cai Lue', isPMC: true },
Review Comment:
How about using `inPPMC`?
##########
website/src/components/committers/index.jsx:
##########
@@ -0,0 +1,53 @@
+import React from 'react'
+import styles from './index.module.css'
+
+// Sorted by apacheId
+const committers = [
+ { githubId: 'ClSlaid', apacheId: 'cailue', name: 'Cai Lue', isPMC: true },
+ { githubId: 'Young-Flash', apacheId: 'dongyang', name: 'Dongyang Zheng',
isPMC: false },
+ { githubId: 'G-XD', apacheId: 'gxd', name: 'Xiangdong', isPMC: false },
+ { githubId: 'Hexiaoqiao', apacheId: 'hexiaoqiao', name: 'Xiaoqiao He',
isPMC: true },
+ { githubId: 'oowl', apacheId: 'junouyang', name: 'Jun Ouyang', isPMC: false
},
+ { githubId: 'dqhl76', apacheId: 'liuqingyue', name: 'Liuqing Yue', isPMC:
false },
+ { githubId: 'Zheaoli', apacheId: 'manjusaka', name: 'Zheao Li', isPMC: false
},
+ { githubId: 'messense', apacheId: 'messense', name: 'Lusheng Lyu', isPMC:
false },
+ { githubId: 'morristai', apacheId: 'morristai', name: 'Morris Tai', isPMC:
false },
+ { githubId: 'WillemJiang', apacheId: 'ningjiang', name: 'Willem Ning Jiang',
isPMC: true },
+ { githubId: 'PsiACE', apacheId: 'psiace', name: 'Chojan Shang', isPMC: true
},
+ { githubId: 'silver-ymz', apacheId: 'silver', name: 'Mingzhuo Yin', isPMC:
true },
+ { githubId: 'sundy-li', apacheId: 'sundyli', name: 'Sundy Li', isPMC: true },
+ { githubId: 'suyanhanx', apacheId: 'suyanhanx', name: 'Han Xu', isPMC: true
},
+ { githubId: 'tedliu1', apacheId: 'tedliu', name: 'Ted Liu', isPMC: true },
+ { githubId: 'tisonkun', apacheId: 'tison', name: 'Zili Chen', isPMC: true },
+ { githubId: 'wu-sheng', apacheId: 'wusheng', name: 'Sheng Wu', isPMC: true },
+ { githubId: 'Xuanwo', apacheId: 'xuanwo', name: 'Hao Ding', isPMC: true },
+ { githubId: 'Ji-Xinyou', apacheId: 'xyji', name: 'Xinyou Ji', isPMC: false }
+]
+
+export default function Committers() {
+ return <>
+ <table>
+ <thead>
+ <tr>
+ <th><b>Avatar</b></th>
+ <th><b>Name</b></th>
+ <th><b>Apache ID</b></th>
+ <th><b>GitHub ID</b></th>
+ </tr>
+ </thead>
+ <tbody>
+ {committers
+ .sort((c0, c1) => c0.apacheId.localeCompare(c1.apacheId))
+ .map(v => (
+ <tr key={v.name}>
+ <td><img width={64} className={styles.contributorAvatar}
+ src={`https://github.com/${v.githubId}.png`}
alt={v.name}/></td>
+ <td>{v.isPMC ? <b>{v.name}</b> : v.name}</td>
+ <td>{v.apacheId}</td>
Review Comment:
We can link to page like https://people.apache.org/phonebook.html?uid=xuanwo
##########
website/community/security.md:
##########
@@ -0,0 +1,15 @@
+---
+title: Security
+---
+
+# Security
+
+The Apache Software Foundation takes a rigorous stance on eliminating security
issues in its software projects. Likewise, Apache OpenDAL is also vigilant and
takes security issues related to its features and functionality into the
highest consideration.
+
+If you have any concerns regarding OpenDAL's security, or you discover a
vulnerability or potential threat, please do not hesitate to get in touch with
the Apache Security Team by dropping an email at [email protected].
Review Comment:
No. Please report to [email protected]
##########
website/src/components/committers/index.jsx:
##########
@@ -0,0 +1,53 @@
+import React from 'react'
+import styles from './index.module.css'
+
Review Comment:
We can also provide a link to
https://people.apache.org/phonebook.html?podling=opendal
##########
website/src/components/committers/index.jsx:
##########
@@ -0,0 +1,53 @@
+import React from 'react'
+import styles from './index.module.css'
+
+// Sorted by apacheId
+const committers = [
Review Comment:
How about keep an order of `committers`? Maybe via `apacheId`?
##########
website/src/components/committers/index.jsx:
##########
@@ -0,0 +1,53 @@
+import React from 'react'
Review Comment:
How about writing a MDX instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
