Xuanwo commented on issue #3724:
URL: 
https://github.com/apache/incubator-opendal/issues/3724#issuecomment-1849406642

   > 2\. Best practice should create temporary files in the same directory as 
the `target + rename`. However `rename` only works if the source and target 
files are on the same filesystem.
   
   Yep. We should make it clean in the docs of `atomic_write_dir`: user should 
specify the dir under same filesystem to make sure it works as expected.
   
   
   
   > 3\. My idea is to add a usage similar method like [fs::atomic_write_dir 
](https://github.com/Xuanwo/hdrs/blob/main/src/client.rs#L443)above `hdrs`, 
whether or not to redesign an api will be discussed and evaluated later.
   
   I feel like `atomic_write_dir` should be an option of 
`opendal::services::Hdfs`, we don't need to touch `hdrs`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to