Xuanwo commented on code in PR #3753:
URL:
https://github.com/apache/incubator-opendal/pull/3753#discussion_r1426718494
##########
website/docusaurus.config.js:
##########
@@ -24,6 +24,9 @@ const lightCodeTheme =
require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const repoAddress = 'https://github.com/apache/incubator-opendal';
+const baseUrl = process.env.BASE_URL ? process.env.BASE_URL : '/';
Review Comment:
Please use `OPENDAL_WEBSITE_BASE_URL`.
##########
website/docusaurus.config.js:
##########
@@ -24,6 +24,9 @@ const lightCodeTheme =
require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const repoAddress = 'https://github.com/apache/incubator-opendal';
+const baseUrl = process.env.BASE_URL ? process.env.BASE_URL : '/';
+const showAnnouncementBar = process.env.SHOW_ANNOUNCEMENT_BAR ?
process.env.SHOW_ANNOUNCEMENT_BAR : false;
Review Comment:
Please use `OPENDAL_WEBSITE_SHOW_ANNOUNCEMENT_BAR`. By the way, the naming
seems confusing. How about use `OPENDAL_WEBSITE_NOT_LATEST`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
