tisonkun commented on code in PR #3761:
URL:
https://github.com/apache/incubator-opendal/pull/3761#discussion_r1427068581
##########
core/src/layers/throttle.rs:
##########
@@ -221,24 +220,22 @@ impl<R: oio::Write> oio::Write for ThrottleWrapper<R> {
loop {
match self.limiter.check_n(buf_length) {
- Ok(_) => return self.inner.poll_write(cx, bs),
- Err(negative) => match negative {
+ Ok(res) => match res {
Review Comment:
It just unfriendly for a reviewer to read this complex logic and reverse
engineering what you do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
