Xuanwo commented on code in PR #3769:
URL:
https://github.com/apache/incubator-opendal/pull/3769#discussion_r1429379140
##########
core/src/services/azblob/core.rs:
##########
@@ -369,6 +372,136 @@ impl AzblobCore {
Ok(req)
}
+ /// Init multipart blob
+ ///
+ /// # Reference
+ ///
+ ///
https://learn.microsoft.com/en-us/rest/api/storageservices/put-block-list?
+ pub async fn azblob_init_multipart_blob_request(
Review Comment:
`Put Block List` is similiar to s3 `CompleteUploads`, we can't use it to
init multipart blob.
##########
core/src/services/azblob/core.rs:
##########
@@ -369,6 +372,136 @@ impl AzblobCore {
Ok(req)
}
+ /// Init multipart blob
+ ///
+ /// # Reference
+ ///
+ ///
https://learn.microsoft.com/en-us/rest/api/storageservices/put-block-list?
+ pub async fn azblob_init_multipart_blob_request(
+ &self,
+ path: &str,
+ args: &OpWrite,
+ ) -> Result<Response<IncomingAsyncBody>> {
+ let p = build_abs_path(&self.root, path);
+
+ let url = format!(
+ "{}/{}/{}?comp=blocklist",
+ self.endpoint,
+ self.container,
+ percent_encode_path(&p)
+ );
+
+ let mut req = Request::post(&url);
+
+ // Set SSE headers.
+ req = self.insert_sse_headers(req);
+
+ // todo: set correct CONTENT_LENGTH
Review Comment:
Maybe we should remove this todo?
##########
core/src/services/azblob/backend.rs:
##########
@@ -533,6 +533,7 @@ impl Accessor for AzblobBackend {
write_can_append: true,
write_with_cache_control: true,
write_with_content_type: true,
+ write_with_content_disposition: true,
Review Comment:
Please enable write_can_mulitple to ensure we cover the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
