Young-Flash commented on PR #3796: URL: https://github.com/apache/incubator-opendal/pull/3796#issuecomment-1867264780
great work. I see there are many changes like ```diff -#[async_trait] +#[cfg_attr(not(target_arch = "wasm32"), async_trait)] +#[cfg_attr(target_arch = "wasm32", async_trait(?Send))] ``` and some just ```diff -#[async_trait] ``` is `#[async_trait]` originally unnecessary for the latter cases? (since there are no async method in trait?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
