Xuanwo commented on code in PR #3806:
URL:
https://github.com/apache/incubator-opendal/pull/3806#discussion_r1435131910
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features
--features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features
--features=services-s3,services-azblob
Review Comment:
> To group those services that are already available under wasm32?
I feel like this feature flag is meaningless. I don't want to expose arch
related feature flag to users.
Adding an array in shell is good enough to me.
##########
.github/workflows/ci.yml:
##########
@@ -305,7 +305,7 @@ jobs:
- name: Build
run: |
rustup target add wasm32-unknown-unknown
- cargo build --target wasm32-unknown-unknown --no-default-features
--features=services-s3
+ cargo build --target wasm32-unknown-unknown --no-default-features
--features=services-s3,services-azblob
Review Comment:
> To group those services that are already available under wasm32?
I feel like this feature flag is meaningless. I don't want to expose arch
related feature flag to users.
Adding an array in shell is good enough to me for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
