Xuanwo commented on code in PR #4029:
URL: https://github.com/apache/opendal/pull/4029#discussion_r1459148582
##########
core/src/services/icloud/core.rs:
##########
@@ -224,6 +240,19 @@ impl IcloudSigner {
);
}
+ if !self.data.cookies.is_empty() {
+ let cookies: Vec<String> = self
Review Comment:
> Apple server will check 'X-APPLE-WEBAUTH-USER cookie' in cookies.If we
don't
[update](https://github.com/apache/opendal/pull/4029/files#diff-011a9dd521c8bd6dce3013689fedea6cd090ba73ebc886ab2ed809c2696aa2eeR186)
in `authenticate request(setup.icloud.com/setup/ws/1)` to keep value in
`seesionData`，the next `sign` cookies are useless.
We don't need to. `reqwest` will handle `COOKIES` and `SET-COOKIES` headers
exactly the same as you do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
