tisonkun commented on code in PR #4134:
URL: https://github.com/apache/opendal/pull/4134#discussion_r1477020121
##########
bin/oay/Cargo.toml:
##########
@@ -51,7 +51,7 @@ dav-server-opendalfs = { path =
"../../integrations/dav-server", optional = true
dirs = "5.0.1"
futures = "0.3"
futures-util = { version = "0.3.29", optional = true }
-opendal.workspace = true
+opendal = { path="../../core" }
Review Comment:
IIRC when publish crate to cargo, it requires all deps are not `path` or
under the same workspace. Do we break the rules here or we don't publish this
crate and thus should add a `publish = false` property?
##########
bin/ofs/Cargo.toml:
##########
@@ -39,7 +39,7 @@ futures-util = "0.3.30"
libc = "0.2.151"
log = "0.4.20"
nix = { version = "0.27.1", features = ["user"] }
-opendal.workspace = true
+opendal = {path="../../core"}
Review Comment:
Ditto https://github.com/apache/opendal/pull/4134/files#r1477020121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
