Xuanwo commented on code in PR #4135:
URL: https://github.com/apache/opendal/pull/4135#discussion_r1477096059
##########
.github/workflows/bindings_python.yml:
##########
@@ -82,6 +86,10 @@ jobs:
- uses: actions/checkout@v4
- name: Setup Rust toolchain
uses: ./.github/actions/setup
+ - name: Ruff Check
+ uses: jpetrucciani/[email protected]
Review Comment:
Install ruff should be simple by calling pip install. Please don't use extra
actions so that we don't need to review and maintain them.
##########
.github/workflows/bindings_python.yml:
##########
@@ -60,6 +60,10 @@ jobs:
- uses: actions/checkout@v4
- name: Setup Rust toolchain
uses: ./.github/actions/setup
+ - name: Ruff Check
Review Comment:
The check results are the same on all platforms, so we don't need to check
everywhere. How about checking it in the sdist job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
