reswqa commented on code in PR #4477:
URL: https://github.com/apache/opendal/pull/4477#discussion_r1562735648
##########
core/src/services/onedrive/writer.rs:
##########
@@ -44,24 +44,24 @@ impl OneDriveWriter {
}
impl oio::OneShotWrite for OneDriveWriter {
- async fn write_once(&self, bs: Bytes) -> Result<()> {
+ async fn write_once(&self, bs: Buffer) -> Result<()> {
let size = bs.len();
if size <= Self::MAX_SIMPLE_SIZE {
self.write_simple(bs).await?;
} else {
- self.write_chunked(bs).await?;
+ self.write_chunked(bs.to_bytes()).await?;
Review Comment:
`write_chunked` splits continuous data in chunks. The migration to `Buffer`
should not be trivial. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
