reswqa commented on code in PR #4734:
URL: https://github.com/apache/opendal/pull/4734#discussion_r1639192127
##########
bindings/python/Cargo.toml:
##########
@@ -157,8 +157,8 @@ futures = "0.3.28"
opendal = { version = "0.47.0", path = "../../core", features = [
"layers-blocking",
] }
-pyo3 = { version = "0.20.1", features = ["abi3", "abi3-py311"] }
-pyo3-asyncio = { version = "0.20", features = ["tokio-runtime"] }
+pyo3 = { version = "0.21.2", features = ["abi3", "abi3-py311"] }
+pyo3-asyncio = { package = "pyo3-asyncio-0-21", version = "0.21", features =
["tokio-runtime"]}
Review Comment:
Pyo3's built-in async-io support is not quite perfect yet. So I prefer we
still stick with `pyo3-asyncio` at this stage.
NB. We use a [fork](https://crates.io/crates/pyo3-asyncio-0-21) from David
here. This may be the base for a permanent fork in the future, depending on the
status of the original `pyo3-asyncio` maintainer. You could also refer to this
[comment](https://github.com/awestlake87/pyo3-asyncio/issues/119#issuecomment-2166720029).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
