meteorgan commented on code in PR #4881:
URL: https://github.com/apache/opendal/pull/4881#discussion_r1674175719


##########
core/src/types/operator/operator_futures.rs:
##########


Review Comment:
   the function comments in `FutureWrite` and other related structs are not 
unified and confusing.
   for example: 
   
   1. Set the append mode of op
   2. Set the content type of option
   3. Set the executor for this operation
   
   Is the op, option, operation the same meaning ? shall we unify them ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to