Lzzzzzt opened a new issue, #4888:
URL: https://github.com/apache/opendal/issues/4888
### Feature Description
Since the `CompleteAccessor` stores the metadata, and `Access::info` return
the `Arc<AccessorInfo>`, we can move logic from `fn metadata(&self) ->
Arc<AccessorInfo>` to `impl<A: Access> Layer<A> for CompleteLayer` to avoid
creating a new `Arc<AccessorInfo>`(this is not add the reference count).
### Problem and Solution
just change `CompleteAccessor::metadata`:
```rust
fn metadata(&self) -> Arc<AccessorInfo> {
let mut meta = (*self.meta).clone();
let cap = meta.full_capability_mut();
if cap.list && cap.write_can_empty {
cap.create_dir = true;
}
meta.into()
}
```
to
```rust
fn metadata(&self) -> Arc<AccessorInfo> {
self.meta.clone()
}
```
and change `CompleteLayer::layer`:
```rust
fn layer(&self, inner: A) -> Self::LayeredAccess {
CompleteAccessor {
meta: inner.info(),
inner: Arc::new(inner),
}
}
```
to
```rust
fn layer(&self, inner: A) -> Self::LayeredAccess {
let mut meta = inner.info().as_ref().clone();
let cap = meta.full_capability_mut();
if cap.list && cap.write_can_empty {
cap.create_dir = true;
}
CompleteAccessor {
meta: meta.into(),
inner: Arc::new(inner),
}
}
```
### Additional Context
All the layers that store the metadata can apply this change.
### Are you willing to contribute to the development of this feature?
- [X] Yes, I am willing to contribute to the development of this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
