Xuanwo commented on code in PR #4896:
URL: https://github.com/apache/opendal/pull/4896#discussion_r1678845940
##########
core/src/layers/complete.rs:
##########
@@ -382,7 +389,7 @@ impl<A: Access> LayeredAccess for CompleteAccessor<A> {
// Todo: May move the logic to the implement of Layer::layer of
CompleteAccessor<A>
fn metadata(&self) -> Arc<AccessorInfo> {
- let mut meta = (*self.meta).clone();
+ let mut meta = self.meta.as_ref().clone();
let cap = meta.full_capability_mut();
if cap.list && cap.write_can_empty {
Review Comment:
Yep, since we have created the `Arc<AccessInfo>` during `layer()`, we can
remove the dup code here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
