Xuanwo commented on code in PR #4995:
URL: https://github.com/apache/opendal/pull/4995#discussion_r1712904721
##########
bindings/python/tests/test_read.py:
##########
@@ -57,6 +57,16 @@ def test_sync_reader(service_name, operator, async_operator):
read_content = reader.read(size + 1)
assert read_content is not None
assert read_content == content
+
+ read_content = b""
+ with operator.open(filename, "rb") as reader:
Review Comment:
Hi, please fix the existing test case here:
```
read_content = reader.read()
assert read_content is not None
assert read_content == content
```
##########
bindings/python/tests/test_read.py:
##########
Review Comment:
Would you like to help fix `test_async_reader` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]